More efficent coding

im working on pezio , homemade led string translate pezio taps led readout. have far.

code: [select]


const int knocksensor = a0;
const int threshold1 = 0;
const int threshold2 = 113;
const int threshold3 = 227;
const int threshold4 = 340;
const int threshold5 = 453;
const int threshold6 = 566;
const int threshold7 = 679;
const int threshold8 = 851;
const int threshold9 = 1023;
int led1 = 1;
int led2 = 2;
int led3 = 3;
int led4 = 4;
int led5 = 5;
int led6 = 6;
int led7 = 7;
int led8 = 8;
int led9 = 9;


int sensorreading = 0;     


void setup() {
  pinmode(led1, output);
  pinmode(led2, output);
  pinmode(led3, output); 
  pinmode(led4, output);
  pinmode(led5, output);
  pinmode(led6, output);
  pinmode(led7, output);
  pinmode(led8, output);
  pinmode(led9, output);
}

void loop() {
  if (sensorreading >= threshold1) {
    digitalwrite(led1, high);
    }
  if (sensorreading >= threshold2) {
    digitalwrite(led2, high);
    delay(100);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold3){
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(100);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold4) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(100);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold5) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(50);
    digitalwrite(led5, high);
    delay(100);
    digitalwrite(led5, low);
    delay(50);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold6) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(50);
    digitalwrite(led5, high);
    delay(50);
    digitalwrite(led6, high);
    delay(100);
    digitalwrite(led6, low);
    delay(50);
    digitalwrite(led5, low);
    delay(50);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold7) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(50);
    digitalwrite(led5, high);
    delay(50);
    digitalwrite(led6, high);
    delay(50);
    digitalwrite(led7, high);
    delay(100);
    digitalwrite(led7, low);
    delay(50);
    digitalwrite(led6, low);
    delay(50);
    digitalwrite(led5, low);
    delay(50);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold8) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(50);
    digitalwrite(led5, high);
    delay(50);
    digitalwrite(led6, high);
    delay(50);
    digitalwrite(led7, high);
    delay(50);
    digitalwrite(led8, high);
    delay(100);
    digitalwrite(led8, low);
    delay(50);
    digitalwrite(led7, low);
    delay(50);
    digitalwrite(led6, low);
    delay(50);
    digitalwrite(led5, low);
    delay(50);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold9) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(50);
    digitalwrite(led5, high);
    delay(50);
    digitalwrite(led6, high);
    delay(50);
    digitalwrite(led7, high);
    delay(50);
    digitalwrite(led8, high);
    delay(50);
    digitalwrite(led9, high);
    delay(100);
    digitalwrite(led9, low);
    delay(50);
    digitalwrite(led8, low);
    delay(50);
    digitalwrite(led7, low);
    delay(50);
    digitalwrite(led6, low);
    delay(50);
    digitalwrite(led5, low);
    delay(50);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
}


thanks help

code: [select]


const int knocksensor = a0;
const int threshold1 = 0;
const int threshold2 = 113;
const int threshold3 = 227;
const int threshold4 = 340;
const int threshold5 = 453;
const int threshold6 = 566;
const int threshold7 = 679;
const int threshold8 = 851;
const int threshold9 = 1023;
int led1 = 1;
int led2 = 2;
int led3 = 3;
int led4 = 4;
int led5 = 5;
int led6 = 6;
int led7 = 7;
int led8 = 8;
int led9 = 9;


int sensorreading = 0;     


void setup() {
 
  for(int i=1;i<=9;i++){
    pinmode(i, output);
  }
 
 
}

void loop() {
  if (sensorreading >= threshold1) {
    digitalwrite(led1, high);
    }
  if (sensorreading >= threshold2) {
    digitalwrite(led2, high);
    delay(100);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold3){
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(100);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold4) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(100);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold5) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(50);
    digitalwrite(led5, high);
    delay(100);
    digitalwrite(led5, low);
    delay(50);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold6) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(50);
    digitalwrite(led5, high);
    delay(50);
    digitalwrite(led6, high);
    delay(100);
    digitalwrite(led6, low);
    delay(50);
    digitalwrite(led5, low);
    delay(50);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold7) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(50);
    digitalwrite(led5, high);
    delay(50);
    digitalwrite(led6, high);
    delay(50);
    digitalwrite(led7, high);
    delay(100);
    digitalwrite(led7, low);
    delay(50);
    digitalwrite(led6, low);
    delay(50);
    digitalwrite(led5, low);
    delay(50);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold8) {
    digitalwrite(led2, high);
    delay(50);
    digitalwrite(led3, high);
    delay(50);
    digitalwrite(led4, high);
    delay(50);
    digitalwrite(led5, high);
    delay(50);
    digitalwrite(led6, high);
    delay(50);
    digitalwrite(led7, high);
    delay(50);
    digitalwrite(led8, high);
    delay(100);
    digitalwrite(led8, low);
    delay(50);
    digitalwrite(led7, low);
    delay(50);
    digitalwrite(led6, low);
    delay(50);
    digitalwrite(led5, low);
    delay(50);
    digitalwrite(led4, low);
    delay(50);
    digitalwrite(led3, low);
    delay(50);
    digitalwrite(led2, low);
  }
  if (sensorreading >= threshold9) {
   
  for(int i=2;i<=9;i++){
         digitalwrite(i, high);
         delay(50);
      }
     delay(50);


  for(int i=9;i>=2;i--){
digitalwrite(9, low);
delay(50);
   }
   
  }
}



ect.......

Arduino Forum > Using Arduino > Programming Questions > More efficent coding

arduino